Sibtain Ali

Results 150 comments of Sibtain Ali

## Reviewer Checklist - [x] I have verified the author checklist is complete (all boxes are checked off). - [x] I verified the correct issue is linked in the `###...

I don't think we need a test case for this. In the PR, the test steps just mentioned opening the app and verifying if it crashed or not.

## Reviewer Checklist - [x] I have verified the author checklist is complete (all boxes are checked off). - [x] I verified the correct issue is linked in the `###...

## Proposal ### Please re-state the problem that we are trying to solve in this issue. Different font size for inline and multiline code block ### What is the root...

> In `src/components/ThreeDotsMenu/index.tsx` the `isBehindModal` variable and `useEffect()` function should be removed entirely as they are not needed. Without them, the onPress event is the only thing determining when to...

> My solution still works for this case, because the popover menu is closed on blur (not by a close button). So anytime the user does anything it is already...

Thanks for your proposal @kmbcook. I see that your solution is similar to what @rayane-djouah proposed earlier. You're suggesting to apply the same fix at a different place. Is there...

I'm leaning towards @rayane-djouah's [proposal](https://github.com/Expensify/App/issues/37609#issuecomment-1975228336) since it fixes the problem at its root. The other proposals seem to be more of a patch work on the original problem. That being...

@bernhardoj I went through your proposal again and I still think that @rayane-djouah's proposal is better. In my opinion, we should not rely on `hideModal` to be called in order...

@CyberAndrii's [proposal](https://github.com/Expensify/App/issues/48475#issuecomment-2336832176) looks good to me. It has the correct RCA and the solution seems to work as well. 🎀 👀 🎀 C+ reviewed