Robin

#12439 Change _observers from list to set

14

## Scope and purpose Fixes #12439 This PR improves the performance of the LogPublisher class by replacing the list used for storing observers with a set. This change optimizes the...

Optimize `LogPublisher.addObserver` by using a set instead of a list

2

**Is your feature request related to a problem? Please describe.** It is not a major issue, but there is a minor performance concern in `LogPublisher.addObserver`. Currently, `LogPublisher` uses a list...

### Description This PR introduces a global random seed set after imports in the test file. This change aims to make the tests more deterministic and easier to debug by...

### Description: While reviewing the get_routable_ip_to function in [torchx/apps/serve/serve.py](https://github.com/pytorch/torchx/blob/main/torchx/apps/serve/serve.py#L96), I noticed that the socket is directly closed using s.close(), without calling shutdown() beforehand. ```python3 def get_routable_ip_to(addr: str) -> str: """...

test: add random seed in conftest

4

This PR adds a fixed `random.seed(42)` to `pytest_configure` in `conftest.py` to ensure deterministic behavior for tests that rely on Python’s random module. This change was motivated by the `test_registry`, which...

### Description An issue in socket handling where the "shutdown-then-close" pattern was not properly implemented in the error handling path of socket connections. As a result, socket lifecycle management is...

refactor: enums to use CaseInsensitiveMixin for has_value

4

### Proposed changes * Added `CaseInsensitiveMixin` to improve code reuse for case-insensitive value checking across Enum classes. * Applied the mixin to the Enuns `StixCyberObservableTypes`, `IdentityTypes`, `ThreatActorTypes`, `LocationTypes`, `ContainerTypes`, `StixMetaTypes`,...

This PR add `await self._writer.wait_closed()` to ensure the connection is fully closed, resources are released, and execution only continues after that.