Robin
Robin
Hi @glyph, do you have any insights on this test failure? Could it be a flaky test? It’s passing in my environment: Test: test_trace File: src/twisted/logger/test/test_observer.py 
I understand, thanks for the explanation, maybe adding a `sorted()` in the test assertion of the tests will solve the problem of reliability?
I understand the overall message. I'm short on time right now, but I'll take care of it as soon as I’m available.
I ran this benchmark separately in PR #12445, and on my machine the results were encouraging. After the changes, the observer add/remove performance improved significantly, especially for larger sets. Before:...
please review
About the performance check: The change in `test_log_publisher_call_dispatch` (from 1.3 ms to 1.4 ms, -6.71%) justifies the significant performance gains in other benchmarks. Notably, `test_log_publisher_add_remove` improved dramatically from 137.2 ms...
Thank you for the responses! I quickly noticed that a benchmark test was incorrect, and the DummyObserver was taking up some time. I opened another PR (#12446) to fix this....
hello @manics, I noticed `test_registry` uses `port = randint(10000, 65535)` in tests methods to pick random ports, which is great for avoiding conflicts. Since there iss a small chance of...
Hey @minrk, Thanks for pointing this out, and I totally understand your concern. These PRs are part of a research project we're conducting, and while we can't share all the...
please review