a_guilhem comments

Results 18 comments of


                                            a_guilhem

[Serializer] Return null and handle as InvalidArgumentException instead of ValueError if the data doesn't belong to a backed enum

Indeed, we could distinguish the type of exception thrown depending on whether there is a constructor or not. - if constructor invalid, the object being not possible to instantiate we...

[Serializer] Return null and handle as InvalidArgumentException instead of ValueError if the data doesn't belong to a backed enum

@issei-m for sure. I will also take into account this PR https://github.com/symfony/symfony/pull/48821

[Serializer] Return null and handle as InvalidArgumentException instead of ValueError if the data doesn't belong to a backed enum

@TerjeBr PR https://github.com/symfony/symfony/pull/48821 doesn't solve your issue ? I can have a look at it :) sorry for the late reply

[Serializer] Return null and handle as InvalidArgumentException instead of ValueError if the data doesn't belong to a backed enum

indeed. I'm glad to have a look at it then for 5.4 !

[Serializer] Return null and handle as InvalidArgumentException instead of ValueError if the data doesn't belong to a backed enum

Would the added test case correspond to your case in https://github.com/symfony/symfony/pull/50192 ?

[DoctrineBridge] doctrine connection listener for long running runtime

@nicolas-grekas @dunglas ok I'll update it and try to decorate the Connection object

[DoctrineBridge] doctrine connection listener for long running runtime

> I don't like the approach, because as @nicolas-grekas mentioned, this will keep pinging the DB every request, even if normally request wouldn't need connection. Can't we make this DBAL...

[DoctrineBridge] doctrine connection listener for long running runtime

@ostrolucky Before refactoring (taking into account `DoctrinePingConnectionMiddleware`), I'm not entirely sure I grasp the specific middleware you're referring to. Are you referring to those related to `Doctrine\DBAL\Driver` `Doctrine\DBAL\Driver\Connection`

[DoctrineBridge] doctrine connection listener for long running runtime

> Are you planning to add some tests? in https://github.com/doctrine/DoctrineBundle/pull/1739 PR

[DoctrineBridge] doctrine connection listener for long running runtime

closing the PR : see https://github.com/doctrine/dbal/pull/6351 and https://github.com/doctrine/DoctrineBundle/pull/1739