robert

Results 6 comments of robert

I think this just boils down to the use of ssh as the git protocol+a nontrivial ssh config. Do you plan on supporting ssh urls for this gh integration?

> Yes, we are working on supporting ssh as the git protocol. Incidentally, here's an ssh-related fix that landed after the initial release: > > [89d7a8a](https://github.com/facebook/sapling/commit/89d7a8aac3cb882960ec62bc81ea2c8c17d74de0) > > It is...

I think, to fully support ssh urls `parse_owner_and_name_from_github_url` should first lookup the host in the ssh file as is decribed [here](https://stackoverflow.com/questions/59305574/given-the-alias-get-the-hostname-from-ssh-config). What do you think?

To be clear, this is the error I'm talking about `panic: {path} did not exist in the database (as either a file or directory) as of that timestamp`

> Wouldn't it be surprising if you restored a directory and it gave you every file that's **ever** been in that directory? How would that work if there were many...

wip here https://github.com/leijurv/gb/pull/28