Adam Bright

Results 7 comments of Adam Bright

Thanks for the review. Most of my work doesn't involve bit-twiddling so I appreciate you taking the time to correct some of my missteps in that regard. I'll get those...

I had a crazy weekend but I believe I've made all of the fixes you suggested and fixed an issue with temperature reading/writing that I had missed in the documentation....

I'll have to study that code some more and read up on two's complement but thanks for the examples. It should be good to go now.

Yes, that was just my own stupidity with the locking. Also, I just fixed the rounding issue. Per section 5.1.2 in the documentation the limit registers are only precise to...

Is there anything else I need to do on this?

Plus all of the get methods on the gRPC generated types are only defined on pointer receivers.