Alita Moore
Alita Moore
> I think this current behavior is correct, but we could add this as an enhancement. > > GitHub considers "skipped" checks as passing. If you want to block merging...
In any case, you _could_ simply fail the skipped check instead of skipping it if a criteria is not met, but then you will be showing the user that the...
@chdsbd we can't use kodiak until this feature is implemented because it allows for circumventing required checks when you go from draft -> PR: https://github.com/ethereum/EIPs/pull/4749
Thank you 🙏🙇♀️
by "not wait" do you mean it will merge it even if it's in progress? but I'll give it a go!
awesome, thank you for clarifying! It may be helpful to include that clarifying point in the docs btw. I wasn't sure if it meant it would ignore that required check.
@chdsbd do you know why this is not merging? I think I may have misunderstood how the setting works. https://github.com/ethereum/EIPs/pull/4700
okay I have confirmed that this did not work because of kodiak timing out
Unfortunately that workaround won't work for the use case. Is there any way to just "kick" it awake every so often automatically in case something like this happens?
also the other required check (Travis CI) didn't pass until 42 so it would make sense that it was marked that status at that time