Ali Ok comments

Results 361 comments of


                                            Ali Ok

Conflicting channel services

Since this is an edge case, I say this is a low priority. It is a good first task, except the upgrade problems.

Defaulting for Channel should resolve the namespace from context, not the resource

This doesn't happen when you apply YAML with `kubectl` since `kubectl` embeds the namespace in the request body.

Defaulting for Channel should resolve the namespace from context, not the resource

sounds good!

Defaulting for Channel should resolve the namespace from context, not the resource

so, - this problem doesn't happen with `kubectl` - `kn` is adding a workaround, that should also be fine - all the other usecases where people are creating `Channel`s programmatically...

Defaulting for Channel should resolve the namespace from context, not the resource

Let's keep this open since this is a `good-first-issue`? At least until the bot marks it stale?

Defaulting for Channel should resolve the namespace from context, not the resource

/remove-lifecycle stale

InMemoryChannel doesn't reject invalid CloudEvents

Thanks @liuchangyan for the heads up. > Would it make sense to add a general CE validation method to either a shared code repository for Knative Eventing or maybe even...

[Experimental] `KReference.Group` to avoid being explicit on the `APIVersion`

#5131 looks good to me. The PR does something *only* if the version is missing the in the subscription ref. That is backward compatible. I don't think this would require...

[Experimental] Spec non-compliance: `spec.subscriber` MUST be set

For reference, this test here is run with no `subscriber` set but only with a `reply` set: https://github.com/knative/eventing/blob/d4244d5b59a67ebfe7f78c412d59c16afc55319e/test/rekt/features/channel/features.go#L79-L101 So, it is actually compliant with the current spec but once `subscriber`...