Alina (Xi) Li
Alina (Xi) Li
Hello, Here is a list of draft PRs that can be reviewed: - https://github.com/apache/arrow/pull/48032 - https://github.com/apache/arrow/pull/48033 - https://github.com/apache/arrow/pull/48050 - https://github.com/apache/arrow/pull/48034 - https://github.com/apache/arrow/pull/48035 - https://github.com/apache/arrow/pull/48036 - https://github.com/apache/arrow/pull/48037 - https://github.com/apache/arrow/pull/48040 - https://github.com/apache/arrow/pull/48041...
> Hmm, it seems draft PRs don't ping me, sorry! If you think the PR is fully ready please un-draft it so I get pinged for review @lidavidm no worries!...
I found more information, the error is caused by `stream` being `undefined` at `this.stream.write(serialize.requestSsl())`
Ohh I see, thanks for letting me know @charmander
I realize this error seems to only be present with unit tests
@lidavidm this draft PR is ready for review! Please have a look
@lidavidm this draft PR is ready for review! Please have a look
@lidavidm this draft PR is ready for review! Please have a look. Please note: https://github.com/apache/arrow/pull/48052#discussion_r2492240445
@lidavidm this draft PR is ready for review! Please have a look
> I'll try to take a look but as an initial comment is the commit about moving from `boost::optional` to `std::optional` required for this PR? [a696be3](https://github.com/apache/arrow/commit/a696be38a45ccb914cd9aca874911570bec9298e) Yes I think so,...