Alin Sinpalean

Results 7 comments of Alin Sinpalean

I am seeing this every single time I make a typo (after I wait 30-60 seconds for RLS to catch up). It could be the setup that's to blame (we...

I fully understand the reasoning against adding yet another argument to some methods. And it's obviously your decision to make as maintainers to prioritize simplicity over security. But I still...

FWIW, I "fixed" this on our end by adding `bincode::deserialize_from` to the list of `disallowed-methods` in `clippy.toml`. So, combined with running `cargo clippy` as part of presubmit tests, this will...

Oh, almost forgot: #430 also switched `process_start_time_seconds` from a `Gauge` to an `IntGauge`. While all other changes in that PR were reasonable (file descriptors, memory usage), `process_start_time_seconds` is also not...

This is an exceedingly rough attempt at enforcing callback limits. I spent a lot of time trying to figure out what was the most appropriate way of passing this available...

FYI, you can create a PR on top of a branch other than `master` (in this case, I believe [mwe/subnet_metrics_exe](https://github.com/dfinity/ic/tree/mwe/subnet_metrics_exe) from #2248 would have been appropriate). Then the change can...

> After inducting a stream slice, the number of signals in the outgoing stream is equal to **_number_of_signals_after_gcing_ + _number_of_messages_inducted_**. So if we want to cap the number of signals...