Alistair Smith
Alistair Smith
Thank you for reporting and opening a pull request! I left a couple notes on the PR :-)
Thanks so much! I'll approve the CI run and hopefully if all is green we can merge shortly.
CI was red but flaky. Thank you for the contribution!
We also need to think about the implications of adding another `bun:*` module. Will we need to update Turbopack again? etc
@riskymh > Is this just a fancier way of --define? Yep, in essence > also how well does it work with dynamic strings? It will not > does it error...
Yep, will find some time today. Thank you @RiskyMH for all of these
These changes look fine and are certainly more accurate than the status quo, so LGTM assuming it's acceptable to reconcile any mistakes in the near future (likely this week, if...
Thank you
Following up here - is there anything we can do at Bun to help get this merged?
Thanks Florian for the notes here! Re/ automation, we'd be happy to set something up to run the necessary scripts in CI and submit a pull request on new releases...