Alistair Smith comments

Results 121 comments of


                                            Alistair Smith

TS2709: Cannot use namespace Serve as a type.

Thanks for reporting! Please use `Serve.Options`, we will update the documentation to match what is true in the types.

feat: add groupBySchema to group types and enums under a namespace

I think namespaces are suitable here In my opinion I believe it's unfortunate that no-namespaces was a default/recommended rule for the TypeScript eslint plugin. I personally usually turn that one...

feat: add groupBySchema to group types and enums under a namespace

~~/snapshot~~ https://github.com/valtyr/prisma-kysely/actions/runs/17353716966/job/49263677824?pr=110

feat: add groupBySchema to group types and enums under a namespace

Let's get this merged. Thank you very much @arthurfiorette for all your efforts working on these changes ❤️

fix(@types/bun): add missing autoloadTsconfig and autoloadPackageJson types

These changes look good but I'm conscious that since these are compile-specific flags, they should exist under the compile key. @jarred-sumner any thoughts about committing to the public API? I...

HTML Import Type Definitions Don't Reflect Import Attribute Behavior

Yes unfortunately I am going to be closing this until there's progress in the issue Risky left. I actually [left a comment there](https://github.com/microsoft/TypeScript/issues/46135#issuecomment-3198734819) a few months ago. We want to...

@types/bun: Update to @types/node@25, fallback to PropertyKey in test expect matchers when `keyof unknown` is used

CI is going to fail because @types/node was updated

fix(bake): queue pending HMR scripts for reuse (#19736)

Hi 👋 Thank you very much for the contribution. We certainly would like to include the fix for this in the next or following release of Bun. With that said,...

fix(bake): queue pending HMR scripts for reuse (#19736)

Specifically the fix is to ensure the new tests here are failing in the current stable version of bun and then seeing them pass in this branch/CI. That way we...

fix(bake): queue pending HMR scripts for reuse (#19736)

Thanks @prekucki however, I think there's an issue with the test itself - it's currently passing on stable Bun (see the image below), which means it's not actually verifying the...