Ali MJ Al-Nasrawy

I've just hit it independently: ```rust trait Trait { type Ty; } impl Trait for () { type Ty = (); } fn test() -> impl Trait {} ``` Regressed...

I like this and I think it is cleaner for `Condition::new` to already accept `Option`. But since this would arguably be an unneccessary breaking change, I think it is better...

> Why would that be a breaking change? I meant changing `Condition::new` to accept Option would be breaking. Sorry for the confusion. I prefer having the implementation on `Condition` because...

> > I don't see the point of this PR. It's like a misunderstanding of the service initialization to me. It is pretty useful for middlewares that doesn't provide an...

Wasn't able to reproduce. Make sure you've set your wrapper under a scope to capture parameters. my test code: ```rust use actix_web::dev::{ResourceDef, Service}; use actix_web::{error, web, App, HttpResponse, HttpServer}; use...

If you want to access a path argument in middleware, you you should add the middleware to a scope that defines such argument (as in the example above), not to...

Using the examples you gave, you have many options: You can add the same middleware to multiple scopes. You can also merge these scopes into one: `scope("/{domain:user|company}/{uid}")` or, if you...

Depends on actix/actix-net#397 FnOnce was chosen for the closure because otherwise it would be incovenient to use - the users are required to clone captures before the async block: ```rust...

TODO: * remove `FromRequest::Output` * have `trait FromRequestOwned: for` * have trait `ArgumentFromRequest` to mimic the function of Output and have a blanket impl for FromRequestOwned

We can think of this as two separate problem domains: * support borrowed extractors when using FromRequest methods directly: This can be easily solved by intoducing the lifetime parameter to...