Ali Elbashir
Ali Elbashir
Thanks for this, i've been struggling with this lib for real time updates with gRPC streaming and faced many bugs related to unsubscribe. Moving to your implementation seems to fix...
If this feature is also wanted for the other languages should I include that within this PR, or should different PRs be opened for each language?
I've noticed there are unit tests in the ruby compiler directory. From what I understand they compare output to the expected files in that dir. This will break that test,...
> Talked with the team about this and we are going to create an easier way to update the expected output for changes like this to decrease the maintenance burden....
Done, please let me know if there's anything else I need to do
Sure thing, doing it now
Apologies, I accidentally pushed an incorrect rebase, which could be the reason for the protobuf-btr and protobuf-docs teams' review requests. I rebased and force pushed so that shouldn't be an...
@deannagarcia it seems that the PR isn't passing the safety check despite having the "safe for tests" label. Is this intentional, if so is there something else I should do...
@deannagarcia any updates regarding this PR?