Alice Frosi

Results 639 comments of Alice Frosi

@aep if you can, you could attend the community meeting on Wend and present the problem. I think, it will be the fastest way to receive feedback

For storage we are completely missing this mapping, and it is a general problem for all PCI passthrough devices. But it is particularly relevant for storage since the devices definitely...

@CharlesQQ have you tried to connect to vnc? Like `virtctl vnc `. Could be that your VM haven't booted correctly

> ### Why we need it and why it was done in this way > The following tradeoffs were made: A VMI status field was added for virt-controller to let...

@jean-edouard a part from small nits the code looks fine to me. However, it would be better to add some unit tests for the backend storage part.

/approve The code looks good to me @awels can you please take a second look?

@xpivarc could you please add a couple of sentences which explain why we can safely remove the `UpdateStatus` wihout replacing it.

@xpivarc overall good and great stuff! I just put some styling comments and questions.

> > @xpivarc could you please add a couple of sentences which explain why we can safely remove the `UpdateStatus` wihout replacing it. > > @alicefr I am not sure...

/approve /hold Putting on hold to address the nits but the code looks good otherwise.