Alfredo Arena
Alfredo Arena
> Thank you for adding the PR! > > I suggested a couple of small changes to apply. > > Also if you have the time, we use link macros...
@RCheesley I resolved all your suggestions
> @alfredoct96 please can you pull in the docs from the master branch? As this is on a private repo we are not able to do that as maintainers! @RCheesley...
> I have made a small suggestion on the wording to make it clear when we are referring to externally tracked pages. > > I think we might need to...
> @alfredoct96 I have had a bit of a struggle trying to rebase your PR - it seems that there is an issue with the branch, but also it is...
> @alfredoct96 it looks like there are a few files where we [need to improve test coverage](https://github.com/mautic/mautic/pull/9493#issuecomment-744508582) before we are able to merge this. Are you able to take a...
> Hi @alfredoct96! Thanks for your PR we just upgraded Mautic to Symfony 4 and this PR will need to be updated. Since we don't have access to your branch,...
> @alfredoct96 Thanks for submitting this PR, do you have time to rebase it this weekend, I will test it directly once you rebase. > > I think this is...
> Hi @alfredoct96! Thanks for your PR we just upgraded Mautic to Symfony 4 and this PR will need to be updated. Since we don't have access to your branch,...
> @alfredoct96 can you take a look at the feedback regarding media/js/app.js needing to be removed? Thanks! @RCheesley @kuzmany sure, i did the revert