Alex Vanyo

Results 189 comments of Alex Vanyo

> The new tests are going to be run through the test task, making it slower but not actually verifying screenshots, right? They should be excluded and the correct task...

> How about we run screenshot tests in their own step instead? I'd like to track how much time they take. Good idea, updated to split those out in the...

Currently, the setup only treats as input as the set of `@Composable` functions annotated with `@Preview`, as opposed to set of all `@Preview` annotations. Then, it applies the dimensions independently,...

> Do you know how Showkase works with [Multipreview](https://developer.android.com/jetpack/compose/tooling#preview-multipreview) annotated previews? They currently aren't supported: https://github.com/airbnb/Showkase/issues/233 > Could we setup Showkase differently for the different modules? That way we could...

One issue with Git LFS: I haven't set it up myself, but my understanding via https://github.com/git-lfs/git-lfs/discussions/4644 is that it is an extra tool that needs to be installed locally by...

Argh, I think I see what happened. Due to https://issuetracker.google.com/127986458, we have `debugImplementation "androidx.fragment:fragment-testing:1.4.1"`, which transitively means we have `androidx.test:core:1.4.0` in the debug runtime classpath. Then, even though we have...

Seemingly blocked on https://github.com/gradle/gradle/issues/20778

Hi Zeliret! For the basic Scaffold that does work (the one that isn't provided by Accompanist), is that a `material` Scaffold or a `material3` scaffold?

I was able to track down what's happening here: There ends up being two `LocalFabPlacement` compositions locals. One that is defined by `androidx.compose.material`, [here](https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/material/material/src/commonMain/kotlin/androidx/compose/material/Scaffold.kt;l=367;drc=5f442ff2a5ea30cc8d49888554a31d20c66c9dce). And the other that is defined...