Alex Tomlinson
Alex Tomlinson
What is your plan with the data tree? It has some nice properties that I'd like not to lose. In particular: automatic hierarchical name space, easy to add counters to...
In the routes, kvdbs is plural but kvs is not. ``` /kvdbs/{alias}/params /kvdbs/{alias}/kvs/{kvsName}/params ``` I prefer singular: `/kvdb/{alias}/...`
> Alex made a point the other day that we could maybe just drop all the custom logging code and just purely rely on syslog Correction: I said I'd like...
I don't think the CLI should produce JSON by default. I think we used YAML because it was both structured and human readable.
I'm running on master with this PR + a few others merged locally and ran into the following issue. Not sure if it a new issue with this PR or...
Maybe add to the commit comment that this simulates a future version of the CN tree. Don't want anyone to think it it simulates what's in HSE 2.1.x
Many configuration parameters you see in source code are not meant to be changed except for debugging and development. We mark those parameters as "experimental". The non-experimental parameters are described...
If a parameter has the `PARAM_EXPERIMENTAL` flag, then we don't recommend adjusting it. We typically do not adjust those except for test and debug.
~Last PR. No Mas.~ Changing my mind. Rejecting this PR. This RC is baked. Can't change 45 files hours before QA kicks off a round of tests.
| library | stars | watchers | forks | |---|---|---|---| | cJSON | 8.3k | 271 | 2.8k | | yyjson | 2.3k | 54 | 220 | | jansson...