Alex Rudy
Alex Rudy
@abusalimov I agree, moving the thread join inside the the context manager does make this problem go away. However, my particular case happens because I start threads during a test...
_I had to take a long leave of absence from this project, so sorry about the delayed response._ Yes, I think both of these suggestions make sense. - Swallow errors...
I think I got the `SendRequest` and `Connection` pieces working in #1670, but I'm running into what I think is a compiler error. In that PR I still want to...
ServiceFn must be re-usable, so the future returned can't borrow from the surrounding closure. This works: ```rust let path = PathBuf::from("/tmp/my.sock"); let channel = Endpoint::try_from("http://[::]:50051")? .connect_with_connector(service_fn(move |_| { let path...
Using the "real" build system makes sense, and I can see why you want to keep it that way. The problem isn't so much ``zmq.h``, because we could bundle that....
I'm thinking a little harder, and I think it makes more sense in my case to expose the compiler settings more as a single method. I think this can be...
I'd like to propose that this be reviewed as-is, and that we add follow-up issues for the remaining todos, which will all require PRs to land and then releases to...
> @alexrudy Example h2c failed. Thanks! https://github.com/hyperium/tonic/pull/1670/commits/5a579e63cadbe83c9dbe903472490c1d2397c904 contains the fix.
@djc Thanks so much for your initial comments. Overall, I tried to minimally scope the changes here based on what was required to make the tests pass with `hyper` >=...
@djc (just about Axum & Nightly) > Makes sense. So can we bump this independently from the Axum upgrade or is this required to be "exactly" in sync? IMO this...