Alex Hall

Results 848 comments of Alex Hall

@SylvainDe ping for this or any of the three PRs attacking the same problem

I also think #50 would fix it. I work around this in futurecoder with this: ```python import pygments # can be any other pip installed module site_packages = strip_required_suffix(pygments.__file__, "pygments/__init__.py")...

Awesome! In the meantime, I have overhauled tracebacks in futurecoder and introduced DidYouMean. It's working nicely! Occasionally there are exceptions but I can suppress them easily, and if it gives...

+1 for removing exec, see https://github.com/gruns/icecream/issues/87 I quite like the setup in my own packages like https://github.com/alexmojaki/executing which was also initially introduced by @KOLANICH. It's minimal and very standard, see...

I *think* it would be straightforward to make the existing `enable()` and `disable()` return context managers, so they could be used like this, without affecting existing usage. So `ic.enable()` would...

Good point. The implementation would need to be slightly more complicated than what I described. Still seems doable without changing the existing API or creating new functions or arguments.

I agree with @salabim's suggestion, I think `a.hello` is better than `a..hello` for this purpose. @Loriasun did you run the tests with this PR? I suspect many of them now...

Yes. In this code: https://github.com/gruns/icecream/blob/58fb2f454e7b0c7d00946f5cd885bb9a933c1e69/icecream/icecream.py#L329-L335 Using https://github.com/alexmojaki/executing#getting-the-__qualname__-of-the-current-function to get the qualname for `parentFunction` should work.

No I'm suggesting how this feature could be added to the library.

I think the above comment is sufficient. Start by making sure you understand the existing `_getContext` code, and then how to get the qualname from `executing` in isolation (i.e. separately...