Alex Kohler

Results 18 comments of Alex Kohler

I would say we definitely should keep the last line, as it guarantees that `FakeFoo` is still meeting the `abc.Foo` interface, and will generate a compile-time error otherwise. Ideally, if...

I guess this is a duplicate of https://github.com/maxbrunsfeld/counterfeiter/issues/68.

@dnephin I did not find a workaround. I was planning on forking and patching, but I'll gladly reopen this for further discussion.

Hi, thanks for the issue (also, hello to a fellow Auroran :smile:). > Presumably, the intention of this linter is to warn when people have written functions like runtime.Caller and...

> Some kind of configurability would be good, like an ignore_outside_package flag or just an ignore list. Completely agree. Going to keep this issue open as I think this could...

Hey there - it looks like this is a bug - thanks for the report! I like won't have the time to get to this in the immediate future, but...

@rittneje heh, on a second look, you're right. I originally read this bug as a naked return being reported on line 14, not 16. Line 16 reporting a naked return...

> Maybe different guys have different threshold about what's "a handful of lines" That is fair - that threshold should be configurable through the `-l` parameter.

Hey there, thanks for the issue! I'm not sure if we can realistically determine whether or not a given `range` or `for` loop with have duplicate key insertions into a...

Hi, thanks for reaching out. At first glance, it looks like it might be possible to add some sort of check for these types of errors. I'll try to take...