Alex Eftimie comments

Results 88 comments of


                                            Alex Eftimie

fix: Avoid infinite loop in the NotificationsSidebarItem title counter

wrong fixes tag?

fix: use fetchApi instead of explicit identityApi token in remaining plugins

> I wonder why CatalogImportClient and KubernetesBackendClient were exported. Are they supposed to be used outside of their plugins? 🤔 @vinzscam no idea, this is how I found them.

fix: move from event-source-polyfill to fetch-event-source

Actually it seems to work fine (using `yarn dev` in the root, I can see logs fetched via event source), and I can also confirm that fetchApi is being used.

fix: move from event-source-polyfill to fetch-event-source

Also tested the scaffolder, and events stream just like before:

fix: move from event-source-polyfill to fetch-event-source

seems like e2e is broken now. I tried merging master onto my branch, no success to fix them. I doubt the failure relates to the code, will try to reproduce...

fix: move from event-source-polyfill to fetch-event-source

@Rugvip / @benjdlambert can you have another look?

Cannot use fine-grained PATs to add labels to pull requests

Hitting the same issue. Error is `GraphQL: Resource not accessible by personal access token (repository.pullRequest.reviewRequests.nodes.0.requestedReviewer)`

Allow to define prune by default for manual sync applications

In our use case, the issue is that we want `prune` to be enabled, but we lose it every time one rolls back (as automated is emptied during rollbacks and...

When paused, display how long the pause is for.

@zachaller I will work on this one, if it doesn't make it to 1.4 then at least we can use it in the extension

Optionally use material search

(validated this works as expected in https://github.com/alexef/mkdocs-techdocs-core/blob/dev/src/core.py#L22, but I'm yet to validate that using custom settings like the proposed way in this PR will work)