Alex Collins

Results 470 comments of Alex Collins

Issue: https://github.com/argoproj/argo-workflows/issues/6257 PR: fix(controller): Randomly expr expression fail to resolve (#6410)

I think the fix for this would be to revert c29b275d. It is that validation that is preventing its use. The downside of this would be the removal of a...

It is trivial `git revert` to fix this, but you would need to test the fix works for you.

Most users will never need tty. Replacing `os.Exec` with `pty` is risky (reasons should be obvious). I think benefit outweights risk.

The controller rarely panic unless there is a bug in the code. Unfortunately, panics tend to hide the real bug. To fix, change this line of code: https://github.com/argoproj/argo-workflows/blob/cd43bba6c87d185bd1530c03c99b874eeceba966/workflow/controller/operator.go#L2304 To ```golang...

This PR is still a great idea as it makes automation easier and more secure.

I've bumped you both to "maintainer". I hope that should be enough perms. LMK if not.