Alex Eagle
Alex Eagle
Ping @comius
ping @comius
That's true, there was no reply from the reviewers in all that time. But it's disingenuous to use that as a justification when you're the maintainer who didn't reply.
Removed the comment - good to merge now?
@meteorcloudy could you merge please? I'm sad to start the precedent of BCR diverging from the repo it's published from, only because the former has active maintainers with commit access
I'm meeting with Ivo next week and can discuss, but Bazel team is currently planning to archive this repo, and the protobuf repo maintainers rejected this design proposal, so I'm...
Note, `main` is already red before this PR, looks like copybara merged stuff out of google3 without running the OSS tests?
The other answer might be that this helper is intended to be private API, and we should copy-paste logic from it into each ruleset?
https://pnpm.io/symlinked-node-modules-structure is the detailed writeup about the semantics required. The tar file needs to contain a `node_modules` directory with symlinks into a CAS "virtual store" as described there. So we...
@aiuto this is now a significant blocker for rules_nodejs users ready to migrate to rules_js. Was that reply sufficient for you to accept a PR to add the `preserve_symlinks` option?