Alex Eagle
Alex Eagle
Long ago, we disabled the sandbox: https://github.com/aspect-build/rules_swc/blob/29f5a69ec3636920d11c33576f2dc2d295be7a01/.bazelrc#L6-L8 (introduced May 2022 in https://github.com/aspect-build/rules_swc/pull/33) Our fix for this in #272 is just to restore that behavior. By giving up on sandboxing the...
Hi @mksmtn - could you try reproducing this with the `swcx` binary, which is the one that has no NodeJS involved? From your repro, I can't tell if it's a...
@jbedard I'm taking another pass at getting this working. I checked my repro that I filed upstream in https://github.com/swc-project/swc/issues/8265 and it's working correctly now: https://github.com/alexeagle/swc_8265_repro/commit/f1b6331f8fee3ad85d418fb1d5a5e20408b7ab3a however we still get a...
@realtimetodie are you still around and interested in this project? Our guess is that https://github.com/swc-project/swc/commit/7dfdc1221890d373d2e6caf52bc8dee8c20765ca#diff-80747e5885ec3975aab81e2ada0a9d27f3319dc0fb45fa38415e19e9aab629eaR224-R232 is only resolving one hop of the symlink that swc sees for the input file,...
Yay a fix has landed upstream https://github.com/swc-project/swc/pull/8757
ugh @jbedard we are still getting ``` < const _moduleA = require("../../../../../../.cache/bazel/_bazel_runner/4b45c25630ed5c5c6ea70d3e83a5966d/sandbox/linux-sandbox/42/execroot/aspect_rules_swc/examples/paths/src/modules/moduleA"); INFO: From Testing //examples/paths:test_0_test: --- > const _moduleA = require("./modules/moduleA/index"); FAIL: files "examples/paths/src/index.js" and "examples/paths/expected.js" differ. ``` WHY????
@jbedard and I discussed the simple answer to this is just stop using the sandbox by default. SWC actions don't benefit since they are always one-file-in with no dependencies, so...
@Aghassi specifically I think we just recommend ``` # Workaround SWC issue with symlinks common --modify_execution_info=SWCCompile=+no-sandbox ``` I feel like we did this a year ago and then I forgot?...
replaced by #272
Also the error in #331 is about rules_rust being absent, so I don't think this is the fix for it. Maybe we should repro first and figure out if we...