Alex Eagle
Alex Eagle
It just copies these three files https://github.com/bazelbuild/rules_nodejs/blob/master/packages/worker/BUILD.bazel#L28-L46 and the source code is just 200 lines https://github.com/bazelbuild/rules_typescript/blob/master/internal/tsc_wrapped/worker.ts
Yeah let's pull our own copy. At the same time, I'm constantly tripping over the need to load a .proto file from disk at runtime - the require location from...
https://github.com/bazelbuild/rules_nodejs/issues/1726#issuecomment-633651133 has some thoughts about how we might be able to have a --require mode of the worker script. In this usage, the tool would have its own FS watcher...
Slipping this to next release, I don't think anything requires that it happens before then.
We have the `npm_package_bin` rule that understands how to adapt a `nodejs_binary` to run as an action. You ought to use that instead of `genrule` so that the module resolutions...
I'm going to take this as a prompt to fix https://docs.bazel.build/versions/master/be/general.html#genrule > Genrules are generic build rules that you can use if there's no specific rule for the task. If...
https://github.com/bazelbuild/bazel/pull/13382 updates the genrule doc. Note that technically this isn't a regression - the esbuild rule was introduced in 3.2.0 after the flag flip for `--bazel_patch_module_resolver` so that case probably...
Yeah, we don't use runfiles because node.js doesn't know to look there. Even with `--bazel_patch_module_resolver` we only monkey-patch the built-in `require` function to know about runfiles, there are still plenty...
`buildkite_config` doesn't seem like anything in rules_nodejs. Is this something now expected by the Bazel CI?
@fmeum I know you visited a lot of languages in the ecosystem for the other runfiles fixes. I don't recall, did you have a look here as well?