Alexandru Dima

Results 200 comments of Alexandru Dima

AFAIK none of the (code) editor settings ask for a reload. I know disabling the telemetry crash reporter process requires a restart, but the settings that really need a restart...

The standalone APIs are all hooked up, but I believe there is no theming implemented for the standalone editor. So those semantic tokens get looked up, no theming returns, so...

@rcjsuen You could try to do this by providing a custom theme service, (with the first created editor) e.g. ```ts monaco.editor.create(element, opts, { themeService: yourCustomImplementation }); ``` You would then...

@rcjsuen This is indeed a mess, and sorry about that. Semantic highlighting has shipped turned off by default. Due to it being a global setting (not an editor instance setting),...

@rcjsuen Yes, there is a problem again rooted in the default value of `semanticHighlighting.enabled` being false in the shipped version. The model gets created at a time when the setting...

@rcjsuen I've pushed a fix for the case you hit, so now the simple configuration service also emits a change event correctly.

Yes. AFAIK this works somewhat by using theme rules, but the theme rules cannot select semantic token modifiers, they can only target semantic token types and partially modifiers. So this...

We have open sourced.

@matty What error do you get? It would be very helpful for us to see the actual error which you can find either in the View > Output > GitHub...

Reopening since the replacing as many spaces as possible with tabs part is not implemented via #155450