Alex Dewar

Results 62 comments of Alex Dewar

Hmm, I created a merge conflict by merging another `pre-commit` bot PR... Hopefully the bot will figure this out on its own :shrug:

Would you mind adding a description of which test is marked `xfail`? Maybe paste the code in the description or provide a link to it. Then we can have a...

Sorry I didn't see this sooner @HarmonicReflux. I've got notifications on for the repo, but seemingly I don't get notifications about new issues. This issue could do with a bit...

Thanks for the response. There's no rush. And if someone actually is running these tests, then it totally makes sense to keep them. We might as well ping Sara here....

Btw `mypy` is now happy with `parse_xml.py`, but we're still ignoring it in `.pre-commit-config.yaml`. Maybe we should enable `mypy` for it? @AdrianDAlessandro

I've had a look at the code and it seems like it wouldn't be too hard to plumb it in... It already made a list of table image files but...

Ohhhhh I see what's happened. The functionality was *accidentally* removed in #149 and then I later noticed, assumed it was never used, and ripped out all the leftover bits. Oops....

Ah ok. Phew! Glad I didn't just delete something people are actually using 😆. If we decide to implement it, we should do #79 at the same time, so that...

Marking as on hold until we do #134 as it'll probably conflict with that work.

On hold until #142 is done.