alexdawes

Results 8 comments of alexdawes

Offending line seems to be https://github.com/Cimpress-MCP/git2consul/blob/master/lib/consul/index.js#L245. ``` body = body ? body.trim() : ''; ``` Any chance we can remove the trim and do just: ``` body = body ||...

Also https://github.com/Cimpress-MCP/git2consul/blob/master/lib/consul/index.js#L183 and https://github.com/Cimpress-MCP/git2consul/blob/master/lib/consul/index.js#L230 I guess.

https://github.com/Cimpress-MCP/git2consul/pull/151

Newtonsoft encodes the type in a special $type field, and this is used for deserialisation to the correct type. This is as intended, as otherwise during deserialisation the consumer would...

Interesting! The Notifications app uses a `[MessageNamespace("orders")]` attribute to mark this as coming from the Orders app: https://github.com/devmentors/DNC-DShop.Services.Notifications/blob/master/src/DShop.Services.Notifications/Messages/Events/OrderCreated.cs#L7 This is then used within a custom RabbitMQ `NamingConventions` in the common...

Ahh I may have worked out where I was wrong. RawRabbit uses `TypeNameHandling.Auto`: https://github.com/pardahlman/RawRabbit/blob/2.0/src/RawRabbit/DependencyInjection/RawRabbitDependencyRegisterExtension.cs#L57 This means that the `$type` key is only used during serialisation when the object being serialised...

Interesting - @simon-davis did you get anywhere with this? From a quick glance in the source code, I cant actually see any use of `PropertyHeaders.MessageType` (in RawRabbit.Common) so its hard...

Hi @elgonzo - thank you so much for that detail. I had no idea URI validation was so fragile in .NET. I sense I'm about to go into a bit...