Alex Barghi

Results 75 comments of Alex Barghi

I'm seeing 10x speedup in my tests by setting the index and using `.loc` as shown here. Could we increase the priority of this?

The C++ code operates only on vertices but I can always automatically get the start vertices from the provided edges. Also shouldn't the expected result be: ``` indices sources destinations...

Ok, so you want the current behavior, but with the `is_edge_ids` flag specifying whether the weights are edge ids rather than always assuming they are, correct?

My interpretation was that if `is_edge_ids` was true, it should treat the start ids as edge ids and automatically select the vertices from those edges.

ok, so there are 2 problems here: 1. You need to use `cugraph.MultiGraph` since `cugraph.Graph` will automatically drop duplicate edges 2. Apparently it ignores the duplicate edge even when using...

(2) is linked to the `count_and_remove_duplicates` call currently in the C++ code for `uniform_neighbor_sample`. And I would say (1) is expected behavior that we won't fix.

@eriknw is this ready for review?