Alexander Fenster

Results 75 comments of Alexander Fenster

Thanks @summer-ji-eng, it looks great! Left some comments, mostly style+readability. I'll defer reviewing the DIREGAPIC-specific logic to @vam-google.

I can repro the leak, looking. ``` $ node --expose-gc index.js Running 100 times 0: Current mem usage 23.25 MB 1: Current mem usage 23.4 MB 2: Current mem usage...

We post-process the generated .d.ts files ([this](https://github.com/googleapis/gax-nodejs/blob/main/tools/compileProtos.ts) script) so technically we can do whatever we want. Dropping optionals altogether is a scary thing, it will most likely break a lot...

I feel very strongly that this is a wrong solution for the problem. It will definitely put out the fire, and it will hide the real problem behind those `13...