Alexander Fenster

Results 97 comments of Alexander Fenster

Yeah, we don't have a catch-all `try .. catch`: https://github.com/googleapis/gapic-generator-typescript/blob/68f5160bf5781848a38957a550c0f4eeb83e2fd1/typescript/src/protoc-plugin.ts#L21..L33 In a fire-and-forget code such as a generator we normally prefer not to catch any exceptions but throw a lot,...

This one is a valid bugreport / feature request. We do have comments in protos, but apparently protobuf.js ignores the `//`-style comments (it wants `/* */`-style comments). I even proposed...

re: required fields - we mark required fields in protos (with annotations) but those annotations don't map well into the types generated by `pbts`. I need to think how to...

I think it can technically go to `IParseOptions` (right near the `keepCase`) and to the CLI flag of `pbjs` for static proto generation. That way we can make it false...

@JustinBeckwith Not yet, but I'm on my way there (started with #682).

Downgrading to feature request since it's just one API that is affected, and this API violates the recommendations of AIP-140.

Hi @scottbessler, I cannot easily reproduce it (neither with an empty list of properties nor with non-empty list), so I will need to ask you to help us figure out...

@weyert Just to confirm - no memory leak on 3.5.7 but leaking on 3.5.8, with no other changes? The only difference between them is related to the HTTP transport https://github.com/googleapis/gax-nodejs/pull/1431/files...

Not in my plan for this month, and no real complaints from users - I'll downgrade this to a feature request.

> `bind EADDRINUSE null:3000` It seems you are using `@google-cloud/local-auth`, which is pretty much a sample code to show how to implement OAuth2. After logging in, your browser gets redirected...