Alex Alekseyenko
Alex Alekseyenko
`createHintsForClick` is defined such that, when `tabbed` is not set to `true`, a different method is used for finding candidate elements: https://github.com/brookhong/Surfingkeys/blob/fa10d12b9a03dcdf9f6bdcc0860ffa8545f9552a/content_scripts/hints.js#L348-L370 and neither 'cf: https://github.com/brookhong/Surfingkeys/blob/80929a374337120de09d61f384bee556fcb2da33/pages/default.js#L126-L128 nor 'f': https://github.com/brookhong/Surfingkeys/blob/fa10d12b9a03dcdf9f6bdcc0860ffa8545f9552a/content_scripts/normal.js#L1068-L1075 set...
I think I found a problem in the `filterOverlapElements` function. When testing whether the result of `elementFromPoint`: https://github.com/brookhong/Surfingkeys/blob/4a274fe10edb5cae6787339171ec52323ef2eddb/content_scripts/utils.js#L267 contains the element in question: https://github.com/brookhong/Surfingkeys/blob/4a274fe10edb5cae6787339171ec52323ef2eddb/content_scripts/utils.js#L268 ```js el.contains(e) ``` can return `false`...
In case it's helpful, this is what I'm proposing: https://github.com/brookhong/Surfingkeys/pull/1374
@duianto Is this the behavior we want/expect? It seems odd that opening a new line should trigger completion, particularly when there isn't any text to complete.
It looks like `org.el` contains [the following logic](https://github.com/bzg/org-mode/blob/aea1109ef735dd72db97b9255662b9ff5bcecfbc/lisp/org.el#L18981-L18989): ``` elisp ((and (eq type 'src-block) org-src-tab-acts-natively (> (line-beginning-position) (org-element-property :post-affiliated element)) (< (line-beginning-position) (org-with-point-at (org-element-property :end element) (skip-chars-backward " \t\n") (line-beginning-position))))...
Assuming that the specified behavior, `(kbd "TAB")`, is correct, then the triggering of the completion is the issue, right? If so, would it make sense to reinvestigate/reopen either or both...
So it looks like we were leaning pretty heavily on how `ahs-idle-timer` was being used: https://github.com/syl20bnr/spacemacs/blob/532ad2567cba1d57d09e102c385315e7cfa829ec/layers/%2Bspacemacs/spacemacs-navigation/packages.el#L73-L82 I'm not sure how you were supposed to know that, but for what it's...
Awesome, thank you! This is what makes the Emacs community great. The main discussion seems to be happening here: https://github.com/syl20bnr/spacemacs/issues/14880 if we continue the conversation there, we may be able...
Regarding the other two instances of `contains` in `utils.js`: https://github.com/brookhong/Surfingkeys/blob/4a274fe10edb5cae6787339171ec52323ef2eddb/content_scripts/utils.js#L279 https://github.com/brookhong/Surfingkeys/blob/4a274fe10edb5cae6787339171ec52323ef2eddb/content_scripts/utils.js#L220 presumably we could run into the same issue with ShadowRoots, but I don't know if I've encountered it in...
Looks like I missed the 5 year anniversary of this issue 🥳 @brookhong would you be open to changing the styling of the text begin hints? I don't think it...