Alexandre Rieux comments

Results 19 comments of


                                            Alexandre Rieux

Typescript definition file

I added a PR to definitely typed, I just converted the types from Flow to Typescript : https://github.com/DefinitelyTyped/DefinitelyTyped/pull/14114/files

`draw.rectangle` equality check in `componentDidUpdate` broken

Hey @vjpr thanks for the issue, it seems like a critical issue. I am not spending much time maintaining this library to be honest so if you want to go...

add attribute defaultDraw & displayToolbar

Hi @tomsue if anyone want to pick it up I am happy with that

Add optional stylesheet

@sloria That's a good idea, we actually thought about it with @jamiecopeland when we first designed this library but we wanted something as lean as possible in the end. After...

Copy non-react specific statics to decorated component

Do you mean static methods are not copied over when using `createSkeletonProvider` HOC? if so I didn't realise that and would be happy to merge any PR fixing this.

Make prop-types declaration file a dependency

@thchia Thanks for the PR, can you also move `@types/react`, the same should apply to this dependency then

Connector API to access isPending

Hi @SamyPesse, glad to hear you are using `react-skeletor`. I think you can write your own HOC and access the context, that is what a `connectSkeleton ` HOC would do...

Typescript: Map Events are not React.SyntheticEvent

Hey @tobiash , Yes it is an issue, I can fix the types when I have some times, otherwise feel free to open a PR for that 👍

Add fullscreen control

I will de-scope this issue from v3, as it seems there is no big need for this feature atm.

Fix 652 and 603 by adding an id to the geojson feature for Layer component and prevent creating as many layers as there are layer types for geojsonLayer component

Hey @qlerebours sorry for the late reply and thank you for your PR, I agree with the ID fix although for the layer type fix I am not sure this...