alex14
alex14
I went through the same issue ;-)
> @alex14fr Interesting change. Could you split this up a bit? Right now, it's a single 7k line commit. > > Is this a header-only hashing library that you imported?...
> Including dependencies like this is a big no-no. It's also different than what's in the master repo. This should be pulled from upstream. I've modified so as to use...
> @alex14fr you can rehash the 16 byte result using xxh3 64bit to get another 4 bytes. Fo our purpose it should be good enough. What do you think? What...
> Honestly, I don’t like the idea of putting zeros there. Who knows, maybe some code uses only some bytes from the hash value and relies on them being different....
> @alex14fr @algrid @chankongus I still think that we should align the cache to either 4 bytes, if we want to keep exactly 20 bytes, or 8 bytres, if we...
> Current version is strange: in some places it’s 20 bytes, in others it’s 16 (see GlyphRec definition for instance). We need to go back to 20 everywhere. Fixed :-)...