Alex Gaynor
Alex Gaynor
Thanks! On Wed, Oct 16, 2024 at 10:57 PM Robby Cornelissen ***@***.***> wrote: > After discussing with @reaperhulk , we'd > be willing to take a PR (which would go...
We'll need a rust-asn1 release first, but yes On Thu, Oct 17, 2024 at 9:48 PM Robby Cornelissen ***@***.***> wrote: > > If you want, I'll also submit a PR...
Thank you for the contribution, but many of these changes make the Dockerfile harder to read. These are only used in CI, so we're not motivated to shrink the image...
Is there anything I can do to help move this forward?
Tests failing because of Sphinx 8.
Yeah, I think there's a question about how force the system compile to have an `-march=...`. In terms of installer cleverness, I think that'd require a PEP to standardize a...
Looks like this was a bug introduced with the "existing" support. I think the fix here is that `add_subclass` should error when `PyClassInitializerImpl` is an `Existing`.
I'm not sure I follow why you think rejecting `add_subclass` with `Existing` is a partial fix? AFAICT that's the entire source of the problem.
Can you explain the issue with frozen classes? It seems like a distinct issue from the subclassing issue. With respect to `Existing`, the behavior has never worked, and could not...
FWIW, here's a patch that expresses what I was describing: ```diff diff --git a/src/pyclass_init.rs b/src/pyclass_init.rs index 01983c79b..e1d88850d 100644 --- a/src/pyclass_init.rs +++ b/src/pyclass_init.rs @@ -202,6 +202,9 @@ impl PyClassInitializer { S:...