Alexander Papageorgiou

Results 17 comments of Alexander Papageorgiou

I created a custom prompt that can be used to override the `input` type and will allow you to edit the `default` value by pressing the spacebar. The code is...

@SBoudrias tagging in case you missed the issue, looks like very useful functionality which can be added with only a few lines.

While the victimization is a PEBCAK issue (many are surprised it even works including me), block explorers as well as personal wallets being polluted with transactions that overpopulate transaction history...

Based on on-chain code analysis of existing DeFi projects, this change **should never be applied** as it can break existing patterns. For more information, consult: https://github.com/OpenZeppelin/openzeppelin-contracts/issues/3931#issuecomment-1374793188

I am facing the same issue within a Docker container, it would be nice if someone could help. It appears to occur when the code attempts to connect to LevelDB...

Thanks for the swift response @frangio, evaluating just the `currentAllowance` as non-zero is an adequate remediation to the issue. My proposal was to do it conditionally only when `amount_` was...

Updated original issue to illustrate only the need for `require(currentAllowance != 0)`, thanks for the feedback @frangio

An alternative to this would be re-evaluating the rationale behind EIP-20's `MUST` keyword for firing an event in case of a zero-value transfer. Honestly, the use-case of such zero-value events...

> **Strongly disagree.** > > EIP-20 is final. It has been for a long time, and there is no mechanism to update it. Even if we could update it, you...

With regards to DeFi composability, this is not a retroactive change and as such would solely affect the compatibility of OZ ERC-20 tokens with existing protocols. The most serious impact...