Caleb Maclennan

Results 2606 comments of Caleb Maclennan

@mhosken That would work as long as the number of pages taken by the TOC is fixed. If inserting the TOC into the document bumps all the pages up they...

Yes, @rjmunro, you could. It would in fact be pretty pathological. The difference between pass 2 and pass 3 is only going to be different by the _change_ in length...

No, this still needs fixing. I have work arounds for it left and right, including CaSILE that manually checks page counts between runs to guess when this might be an...

Continuing from [this PR review comment thread](https://github.com/sile-typesetter/sile/pull/2249#discussion_r2030136128)... Yes, not only do we have duplicate data, but the data is not as smart as it can/should be. We are stuffing two...

> Also, I am not sure SILE is in a position where changing internals so deeply in each 0.x for little actual (typographically visible) gain. Whether or not this specific...

> Nodes are low-level construct and should probably not have a _direct_ reference to other objects. You *might* be right, but I couldn't explain how. If the node has a...

That's a good question. Or perhaps a patchset that can be rebased on the upstream and then the difference applied as a patch to our vendor version. I think the...

Reviewing the header output code, the logic is clearly broken. The style overrides need to be inside the closure. https://github.com/simoncozens/sile/blob/c6a0c07911e50448acea660fcaf9a7d1a8bdaa55/classes/book.lua#L64-L82 https://github.com/simoncozens/sile/blob/c6a0c07911e50448acea660fcaf9a7d1a8bdaa55/classes/book.lua#L86-L89 In my publishing toolkit I see I've split the...

Yes please on the backport! I'm trying to get the Arch Linux package for freecad building again and it looks like this is the culprit. *Edit:* Yup this is required...

It's not just verbatim, insertions has the same issue. Frames that get split with frame tricks, then overflow content to a new page might not have the right frame name...