Caleb Maclennan

Results 2432 comments of Caleb Maclennan

You mean to tell us the canonical version scheme is no longer beta3+N? What is the world even coming to...

This would address #270, no? Have you run any benchmarks with/without this feature enabled?

Is there a Git attribute we need to set to make checking out the new fixtures that explicitly test carriage returns from getting smudged on checkout?

Please don't do any merging into this branch. I've force pushed several times **to clean up the history** and you keep pushing the dirty commits back into the timeline. Do...

Somehow the new fixture layout for un-normalized tests is running afoul of this heuristic: https://github.com/projectfluent/fluent-rs/blob/main/fluent-syntax/src/serializer.rs#L425-L429 I can actually pass tests by not adding the extra carriage return there, but I...

I was pretty excited to get this feature landed before cutting a release, but I think I'm going to have to delay it. Hopefully we don't have to delay it...

@zbraniecki or @waywardmonkeys (or any other maintainers) has anybody had a spare minute to give this a quick gander?

It does look like some of the setup for the crate tests is leaking into the crate itself. If anybody has a suggestion/PR to fix this I'd facilitate it. So...

This appears to be a symptom of the bundle generator only being mocked up, see #281 and the `todo!()` code in the module.

My PR at #387 should *minimally* deal with this specific hard coding issue my actually re-using the path spec used to create the resource manager in the iterator. This stops...