alerickson
alerickson
All tests are passing now, PR looks good to me, just have one comment regarding whether to use default runspace created by the .Create() method or use current runspace.
@jshigetomi we reviewed your PR, @anamnavi has a couple comments/suggestions. Everything looks good otherwise. Because we can't test these changes until 7.7 is released we're going to hold off on...
Hi @youngturk2, there's no need for aggressive comments, you can read the code of conduct we abide by and ask users to abide by as well here: [code of conduct](https://opensource.microsoft.com/codeofconduct/)....
I completely agree, `-CredentialInfo` makes more sense here
I just took a closer look to address this issue, but `Register-PSResourceRepository` actually does not have a `-Credential` parameter, only a `-CredentialInfo` [parameter]( https://github.com/PowerShell/PSResourceGet/blob/4cd328e3bc36bdacaccf6e37a1bc293f5432db73/src/code/RegisterPSResourceRepository.cs#L92). Somehow the parameter binding mapped it...
It looks like the build isn't working in CI for this PR
It builds fine on my (Windows) machine as well, but I just pulled in your most recent changes and it's (still) not building on the server. We only build on...
@adityapatwardhan's change resolved the build issue (just an incorrect file name), but it looks like many of the tests are failing with the same error: Error parsing server metadata: Could...
I think this PR will need to be broken down to smaller PRs to see what's causing this issue: > Find-PSResource: D:\a\1\s\test\FindPSResourceTests\FindPSResourceContainerRegistryServer.Tests.ps1:76 > [-] Find all versions of resource when...
Unfortunately now the package build is failing: ``` VERBOSE: Invoking build script VERBOSE: Starting DoBuild for Microsoft.PowerShell.PSResourceGet with configuration: Release, framework: net472 VERBOSE: Module output file path: 'D:\a\1\s\out\Microsoft.PowerShell.PSResourceGet' VERBOSE: Module...