Alejandro Benítez-Llambay

Results 14 comments of Alejandro Benítez-Llambay

The error does not seem to be really related to openMP, but to lack of permissions in your temporary directory?

@MatthieuSchaller, I think the consistency between the h assumed by sphviewer and that used in SWIFT/GADGET should be checked and ensured by the user. More kernels can be added if...

I am now revising this. Below some comments. I tried your code with very low resolution and it gave me segmentation fault. Could you try too? e.g., 5x5 pixels? As...

OK. your branch works now. It doesn't seem to return the right mass for low-res images though.

> Having the distances computed pixel-to-pixel is extremely problematic. Consider the case where we have two pixels, with a particle just on the border, and a smoothing length of 0.8....

This doesn't pass the test. ``` import numpy as np from sphviewer.tools import QuickView import matplotlib.pyplot as plt pos = np.random.rand(10000,3) mass = np.ones(10000) total = [] for res in...

> The particle is fundamentally not below the resolution limit though, its kernel overlaps with strictly two or more cells. Putting the particle at the edge just moves the particle...

Thanks a lot Adrien. Indeed, this would be a very nice feature to have implemented. I'll try to review it a soon as I find some time. This is something...

Thanks! If you could send me the math by email, that would be great. I'll wait for the math, but from what I have seen so far, it seems to...

Do you have some thoughts? I thought some more on this and tried a quick implementation of the logic outlined in my previous message. It seems to work for me....