Alexander Haase
Alexander Haase
@TheAssassin The `Sanitizers_FOUND` variable shouldn't be used like in your patch. E.g. if you have a module named `FindFooBar.cmake`, `FooBar_FOUND` wouldn't be set to true, if the module is found,...
Please see the discussion in #16.
You've changed the code in a way, that it'll always search for sanitizers, even if one doesn't want to use them.
No, the sanitizers should be searched on-demand, if the user enabled one of them via `-DSANITIZE_ADDRESS=On ...`. Please give me some hours to elaborate a patch.
That's right, but then we'll have to rework the messages to be displayed, otherwise one could get several warnings / errors if the compiler doesn't know anything about sanitizers. The...
Can you describe a case, where you need this variables? `add_sanitizers()` will handle this internal for you.
I took a look at #18 and found a little problem: when should `Sanitizers_FOUND` be true? Usually, this var is true, if a specific library is found. However, `add_sanitizers()` even...
@TheAssassin I'll comment here to get the discussion coherent. > I'd say it makes only sense to set `Sanitizers_FOUND` to true when at least one of the modules has been...
I've been thinking a bit about this issue. After all, I don‘t think there is any sense in include FPHSA et all. FPHSA is used to tell, if a specific...
Sorry, but I don't get your point. As far as I understand you want to know whether`-fPIE` and `-fpie` flags have to be set, right? Clang sets them automatically when...