Alec Ritson
Alec Ritson
Yeah we have something similar here https://github.com/lunarphp/lunar/blob/1.x/packages/core/src/Observers/UrlObserver.php if that was what you was referring to?
Thanks @wychoong it would be good to have a few test assertions for this as it's quite complex
> > Thanks @wychoong it would be good to have a few test assertions for this as it's quite complex > > Added the test. > > should the observer...
Thanks @KingaOrsii Whilst I agree this could be useful, I'm not sure assuming `vatNumber` in the meta is the correct way as it's not part of the core and undocumented....
Correct :) we can then document and use it properly throughout the core and panel.
There are certainly area's of this addon we want to improve. Is this due to the `price` being a single field and not currency specific?
Indeed. I remember this being spoken about internally a while back and something we do intend to figure out. I can't remember why exactly it wasn't actioned yet.
@ryanmitchell Are able to test against the latest merge #1944 to see if this fixes the problem for you? 🙏
I've adjusted the prune command to use withTrashed, hopefully that'll do it.
Currently this doesn't appear to work properly for multiple paths. For example: ```php Product::query()->whereJsonContainsInsensitive('attribute_data', ['name', 'description'], 'value')->toRawSql() ``` Yields the following query in MySQL ```sql select * from "lunar_products" where...