Alec Ritson comments

Results 159 comments of


                                            Alec Ritson

Fix container resolution and morph map for extended models

@theimerj Looks like there was some overlap with a PR, are you able to take a look at the conflicts?

Fix container resolution and morph map for extended models

Thanks for this PR, I've had a little look and we've discussed it internally briefly, one point we raised was the introduction of `modelClass()` when using eloquent such as: ```php...

Fix container resolution and morph map for extended models

> 1. Ok, I understand your concern, but Lunar's responsibility is to ensure that it always resolves the correct concrete implementation. To me it basically seems wrong to use concrete...

Fix/product variant attribute filling

We've since updated how variant attributes are managed, if this is still deemed relevant feel free to reopen.

Create and sync prices for currencies

> @alecritson could you still manually edit the other currency prices individually if you wanted to, when set to automatic? There is nothing stopping you from editing prices but they...

Create and sync prices for currencies

@glennjacobs Made some tweaks to hopefully solve the problem.

Create and sync prices for currencies

> > The sync toggle isn't relevant on this screen, as it's the default currency. Perhaps we should turn it off and hide if set to default? done

Create and sync prices for currencies

> > https://www.loom.com/share/22461ac4334642df87c4526ea4495cf6?sid=43d36437-f8f7-4dbd-9a38-b09548f34ec5 > > Some strange goings on here! > > @alecritson did you ever look at this? Yeah I couldn't reproduce it

Fix line fetching in order creation

Thanks @maurice-ellis Are you able to provide a test case to show what this is fixing within it's context?

Force Media RM to always have 1 primary record

Just thinking, would this sort of thing be better off in an observer/listener, since media can be changed without the panel this code will never fire.