Caleb Xu

Thanks for taking a look. > I find the changes OK overall, but this PR modifies a file in sdptransform, which is an external dependency that cannot be modified here....

I see, you are referring to https://github.com/versatica/libmediasoupclient/tree/v3/deps/libsdptransform. Would the correct course of action be to open this PR in that repository instead, to make the changes there first?

I see, thanks. It was unclear to me whether here or the other repository was the "upstream". Can I make the CMake-related changes in this PR over there too? The...

Sure, opened https://github.com/versatica/libmediasoupclient/pull/125.

The `sdptransform` target contains a library (`libsdptransform`), and the implicit/default destination for installing those is `lib`. It can be added back of course; my understanding however is that it's unnecessary.

I've done some more tinkering in https://github.com/Homebrew/homebrew-core/pull/85360. #204 does fix the build, but not because it changes `@echo` to `@printf`. It works because it removes `ASM/x86` from `SUBDIRS`. The issue...

I don't think there's any precedent of a Homebrew formula signing Mac binaries. You could have the formula download a signing certificate as a resource and use it to sign...

Ah, I see, that makes more sense. Yes, I think that would be helpful from a packaging perspective, if it's something that you'd be comfortable including. To me it seems...

I think I've resolved the issue in my local use-case by simply making all my `chromedp` invocations share/reuse a single context rather than creating new ones each time. This single...

I'm no longer able to reproduce the issue, at least in the original way that I observed it back in March. The temp folders still accumulate while the program is...