Martti T.

Results 274 comments of Martti T.

Please add tests and explanation what problem and how this change fixes.

Could someone wit actual jaeger instance confirm that it works and I'll merge this PR.

Maybe using https://echo.labstack.com/middleware/logger/#customizable-function-based-requestlogger would make more sense? and you could start using proper logging library like https://github.com/rs/zerolog , https://github.com/uber-go/zap etc

You might want to read https://github.com/labstack/echo/pull/1728#issuecomment-752231745 TLDR: these are there because group middlewares are executed only when there is a route match and these 2 guarantee a match

There was a reason why header binding was not added to `Bind` method. See https://github.com/labstack/echo/pull/1866#issue-877401536

You can not rename existing public variables - this is not backwards compatible and would break others repos compiling

I think this will break `http.Flusher` interface logic. If you partially write response to the client and that part is smaller than limit and now call flush - what will...

Also thread about https://webmasters.stackexchange.com/questions/31750/what-is-recommended-minimum-object-size-for-gzip-performance-benefits

I think that field needs definitely longer description than at the moment. I you way that most of the people would not understand what they are doing and start setting...