Martti T.
Martti T.
This would be good addition. For filter/search form ability to clear set date (for example end date) is useful.
I am adding some context to ```go if err = next(c); err != nil { c.Error(err) } ``` Calling `c.Error(err)` and therefore invoking global error handler `e.HTTPErrorHandler(err)` is necessary evil...
This is OK. It would be probably better to add comment somewhere that middleware probably reports status incorrectly on error. https://github.com/ziflex/lecho/blob/967237ff45a5b5a87414c392d4a6d5813d04d0a0/middleware.go#L142 In that case it is probably `200` (default status)...
Try this ```go func TestName(t *testing.T) { var tagBlocks []TagBlock p := SentenceParser{ OnTagBlock: func(tb TagBlock) error { // one way tagBlocks = append(tagBlocks, tb) return nil }, } m,...
@derekm we can not change context interface by adding new public method as it would be API breaking change.
we are using semantic versioning and adding new method to interface would be breaking (backwards incompatible) change and would require bumping major version of library to `v5`. We do not...
I think this feature is covered now with https://github.com/labstack/echo/pull/2341 This PR allows you to have custom tag with callback that can access context. so you can add anything you want...
closing, see https://github.com/labstack/echo/pull/2411 and `v5`. Current behavior is not going to change in `v4`.
@ioppermann other than that test function should not consist of multiple testcases - divide it to multiple test functions or use table based tests, I think this PR is OK....
I'm having same problem here `php:7.4.9-fpm-alpine` does not output PHP logs to docker. I do not know what has changed, but 2 months ago built image was working (used `php:7.4.3-fpm-alpine`...