Alberto Cuesta Cañada

Stated minimal Yarn and node versions are not enough

2

Node should be 10.22, Yarn 1.22.

Read prices from chainlink paying attention to heartbeat, minAnswer, and maxAnswer

Contango wand

2

Still a draft. I've used copilot quite heavily, and there is a certain risk to this contract. We will need at least an internal audit.

A CompositeMultiOracle, that accepts a Cauldron as master. Once a master has been set, anyone can set sources that are still unset in the oracle to the same value as...

The expected way would be to pass the zero address as the join address, but then the `join.asset()` call will fail.

Option to reduce damage if there is another `eject`, without incurring the risk of making the contract upgradable or adding a do-anything function. The fyToken can now be retrieved after...

Upgradable strategies

1

Using UUPS to make the Strategies upgradable There is a bit of a confusion between `initialize` that takes the place of the constructor, and `init` that allows the first funds...

If `setRewardsToken` is called with the base, pool or fyToken known to the Strategy, it must revert. Otherwise the tokens kept as rewards will be absorbed at one point or...

I [drafted a module](https://github.com/albertocuestacanada/DssJoinLender/blob/f9aa78abe73ed6333a7b88407ae1c90d6432f30e/src/DssJoinLender.sol) that can flash lend collateral held in the `Join` contracts. It could be merged with `flash.sol` to provide the additional functionality. If the borrower specifies the...

So that if used by a bot, it uses profits to pay for gas and become self-sustaining.