Alberto Cuesta Cañada

Results 82 issues of Alberto Cuesta Cañada

This doesn't seem to be a risk, but means that Token/Token vaults will never be repaid after maturity. They probably wouldn't, anyway. They can be cleared by liquidation, at a...

bug

If zero is stored as `chiAtMaturity`, subsequent calls to `_accrual` will revert on a division by zero. The locked fyToken could still be redeemable through a newly deployed contract, but...

bug

Remove all traces of the JoinFactory, FYTokenFactory and PoolFactory as well

[Here](https://github.com/yieldprotocol/vault-v2/tree/master/test) ![image](https://user-images.githubusercontent.com/38806121/169798714-b1c0aa4f-ab96-429c-9cb7-3877b2842b98.png) There is a certain amount of math around the collateralization formula in `level`, which might benefit from being fuzzed. I haven't though of invariants yet.

[Here](https://github.com/yieldprotocol/vault-v2/tree/master/test) ![image](https://user-images.githubusercontent.com/38806121/169798553-e0d67c4f-dc8e-4307-b273-11c60ce4e15a.png)

[Here](https://github.com/yieldprotocol/vault-v2/tree/master/test) ![image](https://user-images.githubusercontent.com/38806121/169799168-bb4e3935-d3aa-4ac2-976d-d53d84ded627.png) Feel free to break this into smaller issues

[Here](https://github.com/yieldprotocol/vault-v2/tree/master/test) ![image](https://user-images.githubusercontent.com/38806121/169798346-55d3720f-3811-47d5-8455-41fbfe7f79ad.png) The Join tests (#416 ) should be ported first

It is possible to have a `transferFrom` function that takes an off-chain signature in lieu of a prior `approval` or `permit`. With regards to `permit` and the regular `transferFrom`, it...

## Abstract Solidity 0.8 is introducing type checking for arithmetic operations, but not for type casting. From my own experience most downcasting is wrapped in SafeMath-like functions in audited contracts....

breaking change :warning:
language design :rage4:
medium effort
high impact
needs design