Alberto Cuesta Cañada
Alberto Cuesta Cañada
This doesn't seem to be a risk, but means that Token/Token vaults will never be repaid after maturity. They probably wouldn't, anyway. They can be cleared by liquidation, at a...
If zero is stored as `chiAtMaturity`, subsequent calls to `_accrual` will revert on a division by zero. The locked fyToken could still be redeemable through a newly deployed contract, but...
Remove all traces of the JoinFactory, FYTokenFactory and PoolFactory as well
[Here](https://github.com/yieldprotocol/vault-v2/tree/master/test)  There is a certain amount of math around the collateralization formula in `level`, which might benefit from being fuzzed. I haven't though of invariants yet.
[Here](https://github.com/yieldprotocol/vault-v2/tree/master/test) 
[Here](https://github.com/yieldprotocol/vault-v2/tree/master/test)  Feel free to break this into smaller issues
[Here](https://github.com/yieldprotocol/vault-v2/tree/master/test)  The Join tests (#416 ) should be ported first
It is possible to have a `transferFrom` function that takes an off-chain signature in lieu of a prior `approval` or `permit`. With regards to `permit` and the regular `transferFrom`, it...
## Abstract Solidity 0.8 is introducing type checking for arithmetic operations, but not for type casting. From my own experience most downcasting is wrapped in SafeMath-like functions in audited contracts....