phoenix icon indicating copy to clipboard operation
phoenix copied to clipboard

Remove the .class parameters

Open javiereguiluz opened this issue 7 years ago • 5 comments

I was inspecting the dependency injection container generated in production and, after MonologBundle removed the .class params in https://github.com/symfony/monolog-bundle/pull/170 and Symfony removed its last .class params in https://github.com/symfony/symfony/pull/21739, DoctrineBundle is the last one that creates these params.

Would a PR to remove these params be accepted? Thanks!

javiereguiluz avatar Feb 25 '17 08:02 javiereguiluz

@stof Should this be targeted at at a V2 version ?

mikeSimonson avatar Feb 25 '17 08:02 mikeSimonson

I'm closing this 2-year-old bundle because there doesn't seem to be much interest about this, which is fine because it's not a big deal anyway. Thanks!

javiereguiluz avatar Mar 09 '19 10:03 javiereguiluz

Reopening - we will create a new 2.0 release in time for ORM 3 and hopefully Symfony 3, so this is still relevant.

alcaeus avatar Mar 09 '19 14:03 alcaeus

While taking a look, this requires some work in symfony/doctrine-bridge, as it relies on the class parameters to configure the correct classes for the various bundles. I'll see if I can come up with a BC way to add this to Symfony 4.4.

alcaeus avatar Aug 24 '19 09:08 alcaeus

Currently blocked by https://github.com/symfony/symfony/pull/33319.

alcaeus avatar Aug 24 '19 10:08 alcaeus

Let's close as fixed since #949 and other PRs. Thanks.

javiereguiluz avatar Feb 07 '23 18:02 javiereguiluz